Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update stack-analysis script: reset_handler is now main() #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2021
Merged

Update stack-analysis script: reset_handler is now main() #2522

merged 1 commit into from
Apr 9, 2021

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Apr 9, 2021

Pull Request Overview

This should have happened in the re-write of memory initialization.

Testing Strategy

Should be fine.

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

hudson-ayers
hudson-ayers approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@hudson-ayers hudson-ayers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might have more false positives (other function names could include "main") but this is just a helper tool so I think that is fine

@hudson-ayers
Copy link
Contributor

bors r+

@hudson-ayers hudson-ayers added the P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny. label Apr 9, 2021
@bors
Copy link
Contributor

bors bot commented Apr 9, 2021

Build succeeded:

@bors bors bot merged commit e784337 into master Apr 9, 2021
@bors bors bot deleted the tools-stack-main branch April 9, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lschuermann lschuermann lschuermann approved these changes

@hudson-ayers hudson-ayers hudson-ayers approved these changes

Assignees
No one assigned
Labels
P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bradjc @hudson-ayers @lschuermann