Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update print_tock_memory_usage.py to properly parse Rust symbols. #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2021
Merged

Update print_tock_memory_usage.py to properly parse Rust symbols. #2530

merged 2 commits into from
Apr 12, 2021

Conversation

phil-levis
Copy link
Contributor

Pull Request Overview

This pull request gets rid of the hacky symbol handling in this tool. Rather than rely on a bunch of special cases for different patterns, it now fully escapes all the control sequences to derive the structure and trait names. This gives much greater precision on the symbols and therefore where space is going.

It now clusters anonymous functions under "Anonymous" and hidden functions (e.g., software floating point) under "Hidden".

Testing Strategy

This pull request was tested by running it on an imix binary.

TODO or Help Wanted

Please let me know if this output is good, or whether it should cluster stuff like &mut T::fmt and &T::fmt into some special categories.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

lschuermann
lschuermann previously approved these changes Apr 10, 2021
View reviewed changes
Copy link
Member

@lschuermann lschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I can confirm it works and the output looks good. Do you mind me removing some trailing whitespace and squashing into your commit?

I also got around to package cxxfilt for Nix, so we can add it to shell.nix once its upstream (might be interesting for @alevy).

@phil-levis
Copy link
Contributor Author

This looks good. I can confirm it works and the output looks good. Do you mind me removing some trailing whitespace and squashing into your commit?

I also got around to package cxxfilt for Nix, so we can add it to shell.nix once its upstream (might be interesting for @alevy).

Feel free to polish as you see fit!

@lschuermann lschuermann force-pushed the tock-binary-size-tool branch from 8d9d097 to 0214c0a Compare April 12, 2021 22:34
lschuermann
lschuermann approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@lschuermann lschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Cleaned up a bit of whitespace, shouldn't have changed anything functionality wise, diff.

Also thanks for the tool, this is pretty awesome!

@phil-levis
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 12, 2021

Build succeeded:

@bors bors bot merged commit b0860b8 into master Apr 12, 2021
@bors bors bot deleted the tock-binary-size-tool branch April 12, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lschuermann lschuermann lschuermann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-levis @lschuermann