Nonvirtualized userspace driver Grant migration fixes #2577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the transition of nonvirtualized userspace drivers to use Grants for tock#2462, the mechanism used to store appslices and upcalls did not propagate Grant enter errors back to userspace. This commit uses ErrorCode's From implementation to propagate these error cases to userspace. Fixes: c2c2002 ("capsules/spi_controller: migrate ...") Reported-by: Philip Levis <[email protected]> Signed-off-by: Leon Schuermann <[email protected]>
Fixes: e9621aa ("capsules: analog comparator use grant") Signed-off-by: Leon Schuermann <[email protected]>
hudson-ayers
approved these changes
May 6, 2021
2 tasks
bradjc
approved these changes
May 6, 2021
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Two fixes (commits) for the ports to nonvirtualized drivers:
capsules/spi_controller: properly propagate Grant enter errors
As part of the transition of nonvirtualized userspace drivers to use Grants for Tock 2.0: implement Callback swapping restrictions (v3) #2462, the mechanism used to store appslices and upcalls did not propagate Grant enter errors back to userspace. This commit uses ErrorCode's From implementation to propagate these error cases to userspace.
Thanks to @phil-levis for reporting!
capsules/analog_comparator: don't reset current_process on upcall
Testing Strategy
This pull request was tested by compiling.
TODO or Help Wanted
@bradjc Not sure about the second one... That might just work as intended? Though it would work differently compared to the other drivers then.
Documentation Updated
Updated the relevant files inor no updates are required./docs,Formatting
make prepush.