Add SPI to RP2040 #2678
Merged
Add SPI to RP2040 #2678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Iulia Luta <[email protected]>
4 tasks
bradjc
reviewed
Jul 21, 2021
Comment on lines
+152
to
160
| spi0: spi::Spi::new_spi0(), | ||
| sysinfo: sysinfo::SysInfo::new(), | ||
| } | ||
| } | ||
|
|
||
| pub fn set_clocks(&'a self) { | ||
| self.spi0.set_clocks(&self.clocks); | ||
| } | ||
| } |
There was a problem hiding this comment.
Wouldn't it be easier to just pass clocks in as an argument to spi::new()?
There was a problem hiding this comment.
I don't think so, it is a circular dependency, as peripherals has the clock field. I can try though.
There was a problem hiding this comment.
Yeah, that won't work. I used a setup_circular_dependencies() method to address that issue for some other chips, which at least made it only require a single call in the case where there were several circular dependencies.
There was a problem hiding this comment.
I followed your code 😃
bradjc
approved these changes
Jul 21, 2021
hudson-ayers
approved these changes
Jul 21, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 27, 2021
2680: Add Pico Explorer Base development board r=phil-levis a=alexandruradovici ### Pull Request Overview This pull request adds the Pico Explorer Base, a test board around the Raspberry Pi Pico. The Raspberry Pi Pico is not an actual development board, but rather a PCB around the RP2040. Except one single LED, it has no other sensors, buttons or display. The Pico Explorer Base is built around the Pico and provides: - 4 buttons - 240x240 LCD - breadboard ### Testing Strategy This pull request was tested using a Pico Explorer Base. ### TODO or Help Wanted This pull request requires - [x] #2678 - [x] #2679. ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Alexandru Radovici <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request adds SPI to the RP2040.
Testing Strategy
This pull request was tested using a Raspberry Pi Pico.
TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.