Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

brghena
Copy link
Contributor

@brghena brghena commented Aug 6, 2021

Pull Request Overview

Cleans up the section on installing apps and correctly orders arguments to Tockloader so the command works.

Also fixes small spelling/grammar issues.

Testing Strategy

Tested on hardware.

TODO or Help Wanted

Waiting on the resolution of tock/tockloader#72. We might want to change the recommended argument to be a minimum app size instead.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • [N/A] Ran make prepush.

@brghena brghena added the blocked Waiting on something, like a different PR or a dependency. label Aug 6, 2021
Comment on lines +121 to +132
To manually inform Tockloader of the board configuration:
```bash
$ tockloader --openocd --board microbit_v2 --bundle-apps install app.tab
$ tockloader install --openocd --board microbit_v2 --bundle-apps app.tab
```

> `--bundle-apps` seems to be needed due to an [openocd issue](https://github.com/tock/tockloader/issues/67)
> `--bundle-apps` seems to be needed due to an [openocd issue](https://github.com/tock/tockloader/issues/67).
> If you are using an older version of Tockloader, add `--page-size 512` at the end of the command.
>
> ```bash
> $ tockloader ... --page-size 512
> ```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradjc Is there a way to manually specify minimum app size for Tockloader? Or should I leave --bundle-apps here? It matters for people not on the newest Tockloader update.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.

Copy link
Member

@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

I think this should be good to go with the tockloader update

@bors
Copy link
Contributor

bors bot commented Aug 9, 2021

✌️ brghena can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@brghena
Copy link
Contributor Author

brghena commented Aug 12, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 12, 2021

👎 Rejected by label

@brghena brghena removed the blocked Waiting on something, like a different PR or a dependency. label Aug 12, 2021
@brghena
Copy link
Contributor Author

brghena commented Aug 12, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 12, 2021

@bors bors bot merged commit 028fff9 into master Aug 12, 2021
@bors bors bot deleted the microbit_instructions_update branch August 12, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants