Rename allow's argument from slice to buffer #2740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudson-ayers
approved these changes
Aug 9, 2021
alistair23
approved these changes
Aug 9, 2021
bradjc
approved these changes
Aug 9, 2021
lschuermann
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request changes the name of the
allow...'s argument fromslicetobuffer. This better reflects the meaning of the argument as it is not a Rust slice, but abuffershared by a process.While teaching a Tock workshop and explaining the way that the
allow...functions work, I realized that the name seems to confuse students, as it was not clear that the parameter is not a Rust slice, but an entry point to it.Additionally, this pull request updates the porting documentation to reflect the new types.
Testing Strategy
N/A
TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.