litex-sim-ci: pin elf2tab to v0.9.0 to unbreak CI #3206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elf2tab v0.10.0 has a bug which prevents correct calculation of an application's start address in certain cases. Pinning elf2tab to v0.9.0 for now fixes these issues in the CI workflow. Signed-off-by: Leon Schuermann <[email protected]>
75556c8 to
9c538bd
Compare
|
Contributors are starting to wonder why the CI is broken: #3177 (comment) This is a quick solution to get things running again. A proper update of libtock-c, Tockloader and elf2tab will follow as soon as elf2tab has a release in which the start address calculation bug is fixed. I think this is very uncontroversial given that it just effectively restores the state of the CI workflow from a few days ago and I'd appreciate if we can merge this quickly. |
ppannuto
approved these changes
Sep 9, 2022
jrvanwhy
approved these changes
Sep 9, 2022
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
elf2tab v0.10.0 has a bug which prevents correct calculation of an application's start address in certain cases. Pinning elf2tab to v0.9.0 for now fixes these issues in the CI workflow.
Testing Strategy
This pull request was tested by CI?
TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.