boards/opentitan: fixup flash_ctrl test #3213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor fixup to the flash_ctrl tests to make sure we don't overwrite/erase important sections during testing. Bug: When running the entire test suite, ran into an illegal instruction with the instruction being `0xAAAA` which is the data we write into flash in this test (overwritting the code). Signed-off-by: Wilfred Mallawa <[email protected]>
bradjc
approved these changes
Sep 13, 2022
hudson-ayers
approved these changes
Sep 13, 2022
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Minor bug fix to the
flash_ctrltests to make sure we don't overwrite/erase important sections during testing.Discovered: When running the entire test suite, ran into an illegal instruction with the instruction being
0xAAAAwhich is the data we write into flash in this test (overwriting the code on page 5).Flash distribution:
Testing Strategy
Running the test suite on Verilator.
TODO or Help Wanted
N/A
Documentation Updated
Formatting
make prepush.