Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Component: Move ADC components to new _static macro #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2022
Merged

Component: Move ADC components to new _static macro #3231

merged 2 commits into from
Oct 14, 2022

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Sep 20, 2022

Pull Request Overview

This pull request updates the ADC components to use the _static component macro convention and static_buf!().

Testing Strategy

travis

TODO or Help Wanted

Need temperature PR to go through first.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@bradjc bradjc added the blocked Waiting on something, like a different PR or a dependency. label Sep 20, 2022
@bradjc bradjc mentioned this pull request Sep 20, 2022
Closed
2 tasks
@bradjc bradjc force-pushed the component-adc-revamp branch 2 times, most recently from 17e0a37 to 80d8c98 Compare September 26, 2022 17:12
@bradjc bradjc removed the blocked Waiting on something, like a different PR or a dependency. label Sep 26, 2022
@bradjc bradjc force-pushed the component-adc-revamp branch from 80d8c98 to 851a26c Compare October 1, 2022 02:42
phil-levis
phil-levis previously approved these changes Oct 3, 2022
View reviewed changes
alistair23
alistair23 previously approved these changes Oct 4, 2022
View reviewed changes
hudson-ayers
hudson-ayers requested changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@hudson-ayers hudson-ayers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, after some testing, the first commit in this PR causes the compiler to optimize out almost the entire kernel binary of any Tock board that uses the new AdcDedicatedComponent, so this should not be merged until we fix that.

@bradjc bradjc added blocked Waiting on something, like a different PR or a dependency. component labels Oct 6, 2022
@hudson-ayers hudson-ayers mentioned this pull request Oct 12, 2022
Merged
2 tasks
@hudson-ayers hudson-ayers dismissed stale reviews from alistair23 and phil-levis via e27e098 October 12, 2022 23:46
@github-actions github-actions bot added HIL This affects a Tock HIL interface. chips/sam4l Change pertains to the SAM4L MCU. chips/stm32 Change pertains to the stm32 family of MCUSs labels Oct 12, 2022
@hudson-ayers
Copy link
Contributor

rebased on top of #3290

@hudson-ayers hudson-ayers force-pushed the component-adc-revamp branch 2 times, most recently from 09b823b to 7e82437 Compare October 14, 2022 05:16
@github-actions github-actions bot removed chips/sam4l Change pertains to the SAM4L MCU. chips/stm32 Change pertains to the stm32 family of MCUSs HIL This affects a Tock HIL interface. labels Oct 14, 2022
hudson-ayers
hudson-ayers previously approved these changes Oct 14, 2022
View reviewed changes
@bradjc bradjc removed the blocked Waiting on something, like a different PR or a dependency. label Oct 14, 2022
hudson-ayers
hudson-ayers approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@hudson-ayers hudson-ayers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 14, 2022

Build succeeded:

@bors bors bot merged commit effdb87 into master Oct 14, 2022
@bors bors bot deleted the component-adc-revamp branch October 14, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudson-ayers hudson-ayers hudson-ayers approved these changes

@phil-levis phil-levis phil-levis left review comments

+1 more reviewer

@alistair23 alistair23 alistair23 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bradjc @hudson-ayers @alistair23 @phil-levis