Rename appid and app_id to processid #3291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradjc
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
I agree, this seems like the time to finally make this change. When we changed the type to what is now ProcessId we intentionally did not change the variable names to reduce the complexity of that change and hopefully reduce the potential for mistakes. But with proper app id now, seems like now is the time to update the variable names.
hudson-ayers
approved these changes
Oct 11, 2022
alistair23
approved these changes
Oct 12, 2022
ppannuto
approved these changes
Oct 12, 2022
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request renames the usage of
appidandapp_idof typeProcessIdtoprocessid.This is now useful as the
AppIDpull request was merged and the AppID now has a different meaning now from the ProcessId. Most usages ofappidandapp_idactually are referringProcessId.Testing Strategy
N/A
TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.