kernel: hil: rsa_math: Fixup the mutable Client #3309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RsaCryptoBaseMut trait has the incorrect client type for `set_client()`. We should be using `ClientMut` instead of `Client`. Signed-off-by: Alistair Francis <[email protected]>
lschuermann
approved these changes
Nov 1, 2022
hudson-ayers
approved these changes
Nov 1, 2022
twilfredo
approved these changes
Nov 2, 2022
|
Seems to be pretty uncontroversial: bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 2, 2022
3309: kernel: hil: rsa_math: Fixup the mutable Client r=lschuermann a=alistair23 ### Pull Request Overview The RsaCryptoBaseMut trait has the incorrect client type for `set_client()`. We should be using `ClientMut` instead of `Client`. ### Testing Strategy ### TODO or Help Wanted ### Documentation Updated - [X] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [X] Ran `make prepush`. Co-authored-by: Alistair Francis <[email protected]>
|
Timed out. |
|
bors retry |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
The RsaCryptoBaseMut trait has the incorrect client type for
set_client(). We should be usingClientMutinstead ofClient.Testing Strategy
TODO or Help Wanted
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.