Update VolatileCell using the vcell crate's VolatileCell.
#3344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lschuermann
requested changes
Dec 6, 2022
added 3 commits
December 6, 2022 09:17
Tock's `VolatileCell` originally came from the [zinc.rs](https://github.com/hackndev/zinc) project. zinc.rs is no longer maintained. This updates `VolatileCell` by switching to the version from the [vcell](https://github.com/japaric/vcell) crate, which appears to still be maintained. The `volatile_cell.rs` in this commit is `vcell`'s `lib.rs` with the following history comment prepended: ``` // This file was vendored into Tock. It comes from // https://github.com/japaric/vcell, commit // ef556474203e93b3f45f0f8cd8dea3210aa7f844, path src/lib.rs. ```
1. Remove `#![no_std]`, as that is a crate-level attribute, and `volatile_cell` is now a module inside `tock-cells`. 2. Add `#![derive(Default)]`, as Tock uses `VolatileCell::default()`. 3. Run `rustfmt`.
twilfredo
previously approved these changes
Dec 7, 2022
hudson-ayers
previously approved these changes
Dec 7, 2022
alistair23
previously approved these changes
Dec 8, 2022
|
@alevy have you seen this? |
|
Does this change anything other than the order of the methods? Why do we want to add |
alevy
previously approved these changes
Dec 16, 2022
It also changes the license on the code from Apache 2.0 to Apache 2.0 or MIT.
We don't need |
|
I don't think we should add it without explaining why. I guess I would side on not adding it. |
So would you like me to push a commit removing |
7311652
|
I removed |
hudson-ayers
approved these changes
Dec 19, 2022
lschuermann
approved these changes
Dec 23, 2022
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Tock's
VolatileCelloriginally came from the zinc.rs project. zinc.rs is no longer maintained. This updatesVolatileCellby switching to the version from the vcell crate, which appears to still be maintained.Documentation Updated
/docs, or no updates are required.Formatting
make prepush.