Fix nano33 panic by incrementing number of deferred call clients #3362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brghena
approved these changes
Dec 27, 2022
twilfredo
approved these changes
Dec 27, 2022
alistair23
approved these changes
Dec 27, 2022
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request fixes a panic-at-boot on the nano33 caused by bab2b62 . The original implementation did not correctly initialize the i2c stack, presumably causing issues for whatever sensor uses i2c. Switching to the component fixed this bug but did not increment the number of deferred call clients leading to a panic at boot, which is a pain to detect on the nano33 because CDC is not setup yet that early so panic prints do not work.
Testing Strategy
This pull request was tested on my nano33
TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.