Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update rp2040 boards #3399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 15, 2023
Merged

Update rp2040 boards #3399

merged 5 commits into from
Feb 15, 2023

Conversation

alexandruradovici
Copy link
Contributor

@alexandruradovici alexandruradovici commented Feb 14, 2023 •
edited
Loading

Pull Request Overview

This pull request fixes the RP2040 boards:

  • updates the Makefile to use the elf2uf2 utility (using openocd is difficult as it requires additional hardware)
  • adds USB console to Arduino Nano RP2040
  • increases the stack for the boards as using the console hangs up the boards otherwise

It would be great if we could merge this until the Rust Nation presentation.

Testing Strategy

This pull request was tested using a Pico Explorer Base board.

TODO or Help Wanted

N/A

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

lschuermann
lschuermann previously approved these changes Feb 14, 2023
View reviewed changes
hudson-ayers
hudson-ayers reviewed Feb 14, 2023
View reviewed changes
hudson-ayers
hudson-ayers approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@hudson-ayers hudson-ayers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have you confirmed panic prints work ok over the USB console? We had to get pretty creative with that for the nano33ble to really work correctly.

@alexandruradovici
Copy link
Contributor Author

alexandruradovici commented Feb 14, 2023 •
edited
Loading

Looks good, have you confirmed panic prints work ok over the USB console? We had to get pretty creative with that for the nano33ble to really work correctly.

For the RP2040 boards, the panic is still printed over the UART, I did not have the time to update that. The fix in io.rs is mostly a code refactor.

@hudson-ayers hudson-ayers added the last-call Final review period for a pull request. label Feb 14, 2023
@hudson-ayers
Copy link
Contributor

Tagging last-call, will merge by tomorrow unless anyone has issues.

@hudson-ayers
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 15, 2023

Build succeeded:

@bors bors bot merged commit 1095db2 into tock:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lschuermann lschuermann lschuermann approved these changes

@hudson-ayers hudson-ayers hudson-ayers approved these changes

+1 more reviewer

@twilfredo twilfredo twilfredo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
last-call Final review period for a pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexandruradovici @hudson-ayers @lschuermann @twilfredo