nRF52: update usb with new variant #3438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes debugging easier as the full path is needed without adding extra "use" statements.
alistair23
approved these changes
May 21, 2023
|
Any issue with this? |
@bradjc I have an nRF52840DK with me, any advice on how to best test this? |
Um, well, you can combine #3438, #3440, and #3441, and then use tock/libtock-c#324, and you should be able to plug a usb cable into "nRF USB" and you computer and see a string get typed in. |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
As you know, I have a newer variant of the nRF52, and this PR updates the USB driver to handle the newer variant.
Specifically there are now revisions 4 and 5 in the undocumented registers (REVE and REVF) and I went through the errata to ensure 1) there are not new errata and 2) that the old errata still apply.
While I was here I also want to update the commented out code for the debug functions so they are easier to turn on when needed.
Testing Strategy
I have verified I can use the USB stack on the new variant.
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.