make: llvm-tools no longer preview #3443
Conversation
|
This one is easy! |
shell.nix
Outdated
| @@ -73,7 +73,7 @@ let | |||
| ]; | |||
| extensions = [ | |||
| "rust-src" # required to compile the core library | |||
| "llvm-tools-preview" # currently required to support recently added flags | |||
| "llvm-tools" # currently required to support recently added flags | |||
There was a problem hiding this comment.
| "llvm-tools" # currently required to support recently added flags | |
| "llvm-tools-preview" # currently required to support recently added flags |
This breaks on Nix unfortunately. I tried to look into the root cause of this, and it seems that the Rust overlay we use extracts the extensions from the actual upstream Rust package, so it seems there's at least one point in the chain where this rename hasn't propagated.
I tested these changes with llvm-tools-preview and managed to compile a board / run a few makefile commands. Happy to see this merged without this particular change, and I can investigate it when I'm not on airport wifi.
There was a problem hiding this comment.
I reverted the change to shell.nix.
7a9ca6e to
cdda3d3
Compare
|
This one is a real quality of life improvement. |
3439: boards: nrf52840dk: fix ctap example code r=ppannuto a=bradjc ### Pull Request Overview Since we had the CTAP code commented out, it didn't get updated when the component did. ### Testing Strategy compiling ### TODO or Help Wanted n/a ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. 3443: make: llvm-tools no longer preview r=ppannuto a=bradjc ### Pull Request Overview Without this change I was getting: ``` $ make info: component 'llvm-tools' for target 'x86_64-apple-darwin' is up to date ``` on every build. It seems llvm-tools is now a real thing, and no longer a preview. ### Testing Strategy running make ### TODO or Help Wanted n/a ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. 3444: kernel: minor updates to platform.rs r=ppannuto a=bradjc - Reorder the context switch callback getter to match the type def. - Cleanup comments. Minor fixes as I'm looking at (and writing about) this file. ### Testing Strategy n/a ### TODO or Help Wanted n/a ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. 3456: capsules: tickv: do operation after init on already init r=ppannuto a=bradjc ### Pull Request Overview With tickv, if the KV store is already initialized, and a board runs an operation right away, the operation would get queued waiting on the init to finish, but if the init finishes without having to do anything (already inited), the queued operation would never run. This fixes that. ### Testing Strategy testing out tickv on nrf52840dk ### TODO or Help Wanted n/a ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Brad Campbell <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: Response status code: 422
{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Pull Request Overview
Without this change I was getting:
on every build. It seems llvm-tools is now a real thing, and no longer a preview.
Testing Strategy
running make
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.