Avoid building PRs twice through the push and merge_group triggers #3486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub issues its own `merge_group` event when building a PR as part of its merge queue (pushing to a `github-readonly-queue/*` branch). However, we also unconditionally build all pushed branches through the `push` trigger. We can avoid uncessarily building PRs in the merge-queue twice by excluding those special GitHub-created branches in the `push` trigger.
bradjc
approved these changes
Jun 15, 2023
alistair23
approved these changes
Jun 15, 2023
hudson-ayers
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
GitHub issues its own
merge_groupevent when building a PR as part of its merge queue (pushing to agithub-readonly-queue/*branch). However, we also unconditionally build all pushed branches through thepushtrigger. We can avoid uncessarily building PRs in the merge-queue twice by excluding those special GitHub-created branches in thepushtrigger.Testing Strategy
This pull request was tested by merging a PR with this workflow config on a fork.
TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.