tickv: remove get_buffer functions #3491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair23
approved these changes
Jun 18, 2023
|
Please merge this. |
lschuermann
approved these changes
Jun 24, 2023
hudson-ayers
approved these changes
Jul 10, 2023
These would be hard to use correctly, if they can be used correctly, since either tickv should be using the buffers or they are passed back in callbacks.
5d9adc1 to
a5e3f99
Compare
brghena
approved these changes
Jul 18, 2023
alistair23
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
These would be hard to use correctly, if they can be used correctly, since either tickv should be using the buffers or they are passed back in callbacks.
#3489 removes the use of the get_value_buffer after I fixed that the value buffer is provided in the append done callback.
Testing Strategy
This pull request was tested by using the kv app in libtock-c.
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.