Thanks to visit codestin.com
Credit goes to github.com

Skip to content

capsules: remove virtual_[digest|flash|sha].rs which do not virtualize #3503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2023
Merged

capsules: remove virtual_[digest|flash|sha].rs which do not virtualize #3503

merged 3 commits into from
Jul 17, 2023

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Jun 22, 2023

Pull Request Overview

These capsules do not actually provide virtualized digest resources, and I think it's better to not give the impression that we support virtualized digest resources when we do not currently.

Testing Strategy

n/a

TODO or Help Wanted

Thoughts? Obviously another option is to re-write the virtualizers, but someone needs to be willing to do that.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

lschuermann
lschuermann previously approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@lschuermann lschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always resurrect these from git.

@hudson-ayers
Copy link
Contributor

Wait, so like...what do these do now?

@bradjc
Copy link
Contributor Author

bradjc commented Jun 26, 2023

Wait, so like...what do these do now?

Nothing, really. They insert a little code when a HIL function is called, but for the most part the code isn't used. This is because the callbacks are not handled by these capsules, but instead passed directly to the upper layer.

@alevy alevy force-pushed the remove-non-virtualizers branch from e6c14d0 to 68eda7d Compare July 5, 2023 19:53
alevy
alevy previously approved these changes Jul 5, 2023
View reviewed changes
lschuermann
lschuermann previously approved these changes Jul 5, 2023
View reviewed changes
hudson-ayers
hudson-ayers previously approved these changes Jul 10, 2023
View reviewed changes
@hudson-ayers
Copy link
Contributor

This still breaks CI

@hudson-ayers hudson-ayers mentioned this pull request Jul 10, 2023
Closed
@bradjc
Copy link
Contributor Author

bradjc commented Jul 11, 2023

Yeah if there is consensus to doing this then I can remove their uses.

@hudson-ayers
Copy link
Contributor

I am on board

phil-levis
phil-levis previously approved these changes Jul 14, 2023
View reviewed changes
bradjc added 2 commits July 17, 2023 10:30
@bradjc
components: remove virtualizers from components
c601514
@bradjc
boards: ot: remove digest virtualizer
57d6496 
This means choosing between SHA and HMAC (I assume only SHA worked
before). I decided to keep HMAC, rather arbitrarily.
@bradjc bradjc dismissed stale reviews from phil-levis, hudson-ayers, lschuermann, and alevy via 57d6496 July 17, 2023 14:31
@github-actions github-actions bot added WG-OpenTitan In the purview of the OpenTitan working group. component labels Jul 17, 2023
@bradjc
Copy link
Contributor Author

bradjc commented Jul 17, 2023

I removed the uses of the virtualizers from the components and OT.

The digest virtualizer was being used to make both SHA and HMAC available. That wasn't working, but now I had to pick just one.

For future us, on code reviews, we need to check that set_client() (or setup()) is being called at the end of finalize() in components. We really should make that mandatory, or require some explanation as to why it isn't being called. That would have been the easy giveaway that something wasn't quite right here.

@bradjc bradjc mentioned this pull request Jul 17, 2023
Merged
2 tasks
@ppannuto ppannuto mentioned this pull request Jul 17, 2023
Open
@ppannuto ppannuto added this pull request to the merge queue Jul 17, 2023
Merged via the queue into master with commit 70b2b28 Jul 17, 2023
@ppannuto ppannuto deleted the remove-non-virtualizers branch July 17, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppannuto ppannuto ppannuto approved these changes

@alevy alevy alevy left review comments

@phil-levis phil-levis phil-levis left review comments

@lschuermann lschuermann lschuermann left review comments

@hudson-ayers hudson-ayers hudson-ayers left review comments

Assignees
No one assigned
Labels
component WG-OpenTitan In the purview of the OpenTitan working group.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bradjc @hudson-ayers @alevy @ppannuto @phil-levis @lschuermann