kernel: process loading: update comments & remove capabilities #3509
Conversation
We don't need capabilities for non-pub functions.
There was a problem hiding this comment.
I guess I agree with these changes, but I feel like it's going to be an easy mistake to change these functions to be pub, but not take a capability. I wouldn't have an issue passing the capability onward to these internal functions, given that those are the actual process loading implementations for which the capability is actually relevant.
I think this is true of numerous functions in the kernel crate. I think we should keep the use case of capabilities narrow and not speculative. |
Pull Request Overview
In process loading we don't need capabilities for non-pub functions.
Testing Strategy
travis
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.