boards: microbitv2: use helper function in main #3514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By outsourcing all of `main()` to a separate function (in this case `start()` other than running the kernel, we can minimize the stack frame size of main. This is important because the main stack frame is never popped since main does not return. This is an alternative to doing this piecemeal for individual functions.
|
I think I would just return |
|
This PR actually seems to reduce code size for the microbit, and gives us a much smaller main() stack frame (and worst-case stack depth, I am sure). I much prefer this to #3499, and advocate using it for all boards |
35 tasks
2 tasks
alistair23
added a commit
to alistair23/tock
that referenced
this pull request
Jun 28, 2023
Update to use a helper function in main to reduce the stack usage. This is to address the stack usage issue as described in tock#3514. This reverts commit eaffb31. Signed-off-by: Alistair Francis <[email protected]>
|
Maybe |
hudson-ayers
approved these changes
Jul 10, 2023
|
Configuration problem: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
By outsourcing all of
main()to a separate function (in this casestart()other than running the kernel, we can minimize the stack frame size of main. This is important because the main stack frame is never popped since main does not return.This is an alternative to doing this piecemeal for individual functions.
This PR is an alternative to #3499.
Testing Strategy
travis
TODO or Help Wanted
I only did this for one board. Thoughts? Naming? Is using
Chip.unwrap()ok / is there a better option?Documentation Updated
/docs, or no updates are required.Formatting
make prepush.