Fix linker script calculations #3601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that GNU ld is unable to parse some expressions without appropriate spacing around the identifiers. Signed-off-by: Chris Frantz <[email protected]>
alistair23
approved these changes
Aug 9, 2023
lschuermann
approved these changes
Aug 9, 2023
ppannuto
approved these changes
Aug 9, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that GNU ld is unable to parse some expressions without appropriate spacing around the identifiers.
Pull Request Overview
This pull request fixes linker scripts to work with GNU ld. It seems that GNU ld chokes on expressions without spacing around the symbol names:
_etext-_stext-> undefined symbol `_etext-_stext' referenced in expression_etext - _stext.Testing Strategy
This pull request was tested by building the codebase.
TODO or Help Wanted
I think I found all of the expressions without spaces. Please check if I've missed any.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.