kernel_layout: remove eh_frame_hdr #3603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brghena
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
This makes sense to me. There's no way we want eh_frame anything in the binary.
It looks like the flags -fno-asynchronous-unwind-tables and -fno-unwind-tables should also prevent the creation of those DWARF Exception Handling Frames, but even if we added those it should be harmless to also discard them in the LD file.
ppannuto
approved these changes
Aug 10, 2023
bradjc
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
The current kernel_layout does not remove all sections related to the eh_frame. This PR removes all eh_frame related sections.
I was observing a section called eh_frame_hdr within my own project. Removing this section had a 15% decrease to the size of my project. While I did not observe this section on the qemu "board", it could potentially be present on other projects and is worth removing.
Testing Strategy
This pull request was tested by compiling and running the kernel for the qemu_rv32_virt board, as well as 2 other custom boards.
TODO or Help Wanted
Documentation Updated
Formatting
make prepush.