Update deprecated VSCode settings #3628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppannuto
previously approved these changes
Aug 19, 2023
There was a problem hiding this comment.
I don't believe anyone on the core team (except maybe @hudson-ayers) use VSCode, so this has always been something we defer to community folks to maintain. Changes look reasonable to me — thanks!
bradjc
reviewed
Aug 21, 2023
Nope, I use neovim! So no stake in this, but the changes look fine to me. |
|
I am using VS Code, I'll take a look at the changes, but so far they look good to me. |
bradjc
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request removes the
rust-client.channelfield, part of the Rust VSCode extension, which is deprecated as of 15.11.2022, and replaces it with the equivalent setting for the new rust-analyzer extension. However, there could be a case made for developers that install the extension by source code (somehow ? I'm not familiar with this way), as the Github repo is still public, just archived.The second field
"rust-analyzer.check.allTargets": false,was added to fix thefound duplicate lang item ``panic_impl``error and associated squiggles sometimes raised by rust-analyzer, as it runscargo checkwith the--all-targetsflag by default and raises an error for eachpub unsafe extern "C" fn panic_fmt(pi: &PanicInfo)that is not preceded by#[cfg(not(test))].Testing Strategy
This pull request was tested by checking with the official rust-analyzer documentation and restarting the rust-analyzer server to see that the added changes had the desired effects.
TODO or Help Wanted
If there are any suggestion as what more to be enforced upon the VSCode developer, let me know and I'll add them here.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.