Thanks to visit codestin.com
Credit goes to github.com

Skip to content

clippy: -D ptr_eq #3636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2023
Merged

clippy: -D ptr_eq #3636

merged 1 commit into from
Aug 22, 2023

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Aug 21, 2023

Pull Request Overview

This pull request changes code to use core::ptr::eq() instead of ==. I guess this is better?

https://rust-lang.github.io/rust-clippy/master/index.html#/ptr_eq

Testing Strategy

travis

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

lschuermann
lschuermann approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@lschuermann lschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems strictly better, given that:

This is the same as using the == operator, but less generic: the arguments have to be *const T raw pointers, not anything that implements PartialEq.

@lschuermann lschuermann added P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny. last-call Final review period for a pull request. labels Aug 21, 2023
@brghena brghena added this pull request to the merge queue Aug 22, 2023
Merged via the queue into master with commit d60734a Aug 22, 2023
@brghena brghena deleted the clippy-D-ptr_eq branch August 22, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brghena brghena brghena approved these changes

@jrvanwhy jrvanwhy jrvanwhy approved these changes

@lschuermann lschuermann lschuermann approved these changes

@hudson-ayers hudson-ayers hudson-ayers approved these changes

Assignees
No one assigned
Labels
kernel last-call Final review period for a pull request. P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bradjc @brghena @jrvanwhy @lschuermann @hudson-ayers