Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Clippy: Enable many style lints #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Sep 8, 2023
Merged

Clippy: Enable many style lints #3643

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
2eb89c6
clippy: remove old -D flags
bradjc Aug 22, 2023
328a6cc
clippy -D write-with-newline
bradjc Aug 22, 2023
f76a65b
clippy: -D clippy::zero_ptr
bradjc Aug 23, 2023
596f9d1
clippy: -D clippy::unnecessary_lazy_evaluations
bradjc Aug 23, 2023
9216873
clippy: -D clippy::single-component-path-imports
bradjc Aug 23, 2023
da336cf
clippy: -D clippy::redundant_static_lifetimes
bradjc Aug 23, 2023
033cbf3
clippy: -D clippy::match-ref-pats
bradjc Aug 23, 2023
845b3f0
clippy: -D clippy::manual-saturating-arithmetic
bradjc Aug 23, 2023
94899da
clippy: -D clippy::let-unit-value
bradjc Aug 23, 2023
45e8b2c
clippy: -D clippy::init-numbered-fields
bradjc Aug 23, 2023
f693bb6
clippy: -D clippy::excessive-precision
bradjc Aug 23, 2023
79745e6
clippy: -D clippy::bool_assert_comparison
bradjc Aug 23, 2023
2f816a1
clippy: -D clippy::assertions-on-constants
bradjc Aug 23, 2023
16c01f5
clippy: -D clippy::assign_op_pattern
bradjc Aug 23, 2023
f305eb3
clippy: -D clippy::op-ref
bradjc Aug 23, 2023
e29262d
clippy: -D clippy::manual-bits
bradjc Aug 23, 2023
04ff3dd
clippy: -D clippy::needless_late_init
bradjc Aug 23, 2023
53983b5
clippy: -D clippy::neg-multiply
bradjc Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clippy: -D clippy::manual-saturating-arithmetic
  • Loading branch information
@bradjc
bradjc committed Sep 8, 2023
commit 845b3f0ec404129cd1e180c515628bfeef3f3fc0
5 changes: 1 addition & 4 deletions chips/sam4l/src/adc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,10 +507,7 @@ impl<'a> Adc<'a> {
let cpu_frequency = self.pm.get_system_frequency();
let divisor = (cpu_frequency + (1500000 - 1)) / 1500000; // ceiling of division
let divisor_pow2 = math::closest_power_of_two(divisor);
let clock_divisor = cmp::min(
math::log_base_two(divisor_pow2).checked_sub(2).unwrap_or(0),
7,
);
let clock_divisor = cmp::min(math::log_base_two(divisor_pow2).saturating_sub(2), 7);
self.adc_clk_freq
.set(cpu_frequency / (1 << (clock_divisor + 2)));
cfg_val += Configuration::PRESCAL.val(clock_divisor);
Expand Down
1 change: 0 additions & 1 deletion tools/run_clippy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ CLIPPY_ARGS_STYLE="
-A clippy::excessive-precision
-A clippy::init-numbered-fields
-A clippy::let-unit-value
-A clippy::manual-saturating-arithmetic
-A clippy::needless_borrow
-A clippy::op-ref
"
Expand Down