clippy: -D clippy::enum_glob_use #3644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have been enabled long ago.
lschuermann
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
I hate that there's not a more ergonomic way to specify that matches use a given set of enum variants, but I agree that this is better. Specifically it prevents the pitfall of having dangling variants in a match, which are then converted to variables and match on anything.
jrvanwhy
approved these changes
Aug 23, 2023
ppannuto
approved these changes
Aug 23, 2023
brghena
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request enables the https://rust-lang.github.io/rust-clippy/master/index.html#/enum_g lint.
This should have been enabled long ago.
Testing Strategy
travis
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.