Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Aug 31, 2023

Pull Request Overview

This is a new board with nRF52840 and LoRa: https://www.seeedstudio.com/Wio-WM1110-Dev-Kit-p-5677.html

Pretty easy to bring up because it's based on the nrf52840.

We've verified being able to use the temperature sensor and communicate with the LR1110 radio.

Code for userspace under development and will be based on https://github.com/Seeed-Studio/Seeed_Wio_WM1110_Dev_Board/tree/master.

Testing Strategy

running on the board

blink and c_hello work

TODO or Help Wanted

I need to get the bootloader and directions sorted out. Barebones directions now but need to make them more user friendly.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

lschuermann
lschuermann previously approved these changes Aug 31, 2023
Copy link
Member

@lschuermann lschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty uncontroversial, seeing this is -- for now -- just another nRF52840DK board.

@bradjc
Copy link
Contributor Author

bradjc commented Oct 4, 2023

I'm waiting on re-writing the artifact publish CI task for tock-bootloader so I can add installing the bootloader to these instructions.

@github-actions github-actions bot added kernel chips/nrf Change pertains to the nRF5x family of MCUs. labels Nov 29, 2023
@github-actions github-actions bot removed kernel chips/nrf Change pertains to the nRF5x family of MCUs. labels Nov 30, 2023
@bradjc bradjc marked this pull request as ready for review November 30, 2023 20:25
@bradjc
Copy link
Contributor Author

bradjc commented Nov 30, 2023

Ok this is ready to merge. This board file works, and we've verified the temperature sensor works and that we can communicate with the LR1110.

I think at this point we can work on the library in userspace without needing to change the board definition.

@ppannuto ppannuto added the last-call Final review period for a pull request. label Dec 5, 2023
@bradjc
Copy link
Contributor Author

bradjc commented Dec 19, 2023

Last call!

@lschuermann lschuermann added this pull request to the merge queue Jan 11, 2024
Merged via the queue into master with commit 5624c88 Jan 11, 2024
@lschuermann lschuermann deleted the wm1110dev branch January 11, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component last-call Final review period for a pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants