boards: fix clippy ==true #3680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppannuto
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
I think CI let it slide by because clippy is currently marked as a non-required status to merge.
Once all the dust settles on clippy settings, we should probably make it required.
I suspect it would be very annoying in practice as a required check to have the formatting requirements moving underneath other PRs, however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
A couple more of these for the lint.
Testing Strategy
Uh, good question. Why doesn't our CI catch these?!?
TODO or Help Wanted
nothing, hopefully
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.