derive Debug on Value #3687
Merged
derive Debug on Value #3687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps mostly with testing for doing assert_eq instead of comparing using a match on values. Signed-off-by: Andreea Florescu <[email protected]>
lschuermann
approved these changes
Sep 22, 2023
ppannuto
approved these changes
Sep 22, 2023
alistair23
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This helps mostly with testing for doing assert_eq instead of comparing using a match on values.
Fixes: #3670
Testing Strategy
I ran the unit test. I've updated the documentation example of
read_as_enumto use assert_eq directly rather than using a match to compare the values, thus validating that Debug is properly implemented.TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.