Flash error improvement #3697
Flash error improvement #3697
Conversation
|
might be a good idea to rebase and squish the last 3 commits into a single one. Looks like there's some overlap + a merge commit? |
df3e3c6 to
8b4fce4
Compare
Done. |
4f86769 to
a62593e
Compare
|
Rebased. |
| fn tickv_append_key() { | ||
| debug!("start TicKV append key test..."); | ||
|
|
||
| unsafe { | ||
| let tickv = TICKV.unwrap(); | ||
| let sip_hasher = SIPHASH.unwrap(); | ||
|
|
||
| let key_input = static_init!( | ||
| [u8; 16], | ||
| [ | ||
| 0x12, 0x34, 0x56, 0x78, 0x9A, 0xBC, 0xDE, 0xF0, 0x12, 0x34, 0x56, 0x78, 0x9A, | ||
| 0xBC, 0xDE, 0xF0 | ||
| ] | ||
| ); | ||
| let key = static_init!([u8; 8], [0; 8]); | ||
| let value = static_init!([u8; 3], [0x10, 0x20, 0x30]); | ||
| let ret = static_init!([u8; 4], [0; 4]); |
There was a problem hiding this comment.
Why did you remove test cases? Does this PR cause a regression but instead of fixing it you removed the tests?
There was a problem hiding this comment.
Pretty sure I didn't remove them. @bradjc may confirm this.
I didn't perform any tests on actual hardware so I could not be aware of any regression tests. Initially, I only changed the signature of flash methods and a small detail design implementation. However, the detail design was rejected by @bradjc , so there was not any change in code logic.
The sole explanation that I have: it looks like my pull request was merged on 10th October, while yours on 9th October, so your work was overwritten by my pull request. Locally, I still have tickv_test.rs file that you removed. I apologize for my mistake!
There was a problem hiding this comment.
The sole explanation that I have: it looks like my pull request was merged on 10th October, while yours on 9th October, so your work was overwritten by my pull request. Locally, I still have
tickv_test.rsfile that you removed. I apologize for my mistake!
Urgh. I would hope that would have been caught by review to ensure we don't get nasty merge conflicts like this.
That's ok! I was just confused why test cases are being removed
Pull Request Overview
This pull request addresses the issue #3692 .
Testing Strategy
This pull request has not been tested on any hardware yet
TODO or Help Wanted
I need testing on actual hardware to see if everything works as expected.
Documentation Updated
No updates required.
Formatting
make prepush.