Make UART registers for Nrf52840 configurable #3722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for configuration of a second UART
alistair23
approved these changes
Oct 25, 2023
lschuermann
approved these changes
Oct 25, 2023
bradjc
requested changes
Oct 27, 2023
|
@bradjc Just for clarification: |
bradjc
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
On a closer look actually this is fine. I was mixing up io.rs and main.rs and all together got myself confused.
I don't really have a preference between passing in the static ref directly or using an index (and different chips/peripherals do different things) so that is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This PR makes the registers of the UART implementation for the Nrf52840 configurable by passing them into the constructor. This allows boards to re-configure the UART or to support additional UARTs.
Also see the related issue #3720
Testing Strategy
Only changes that can be tested by compilation.
TODO or Help Wanted
No help required.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.