Modified LPS22HB Capsule #3751
Merged
Modified LPS22HB Capsule #3751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the capsule was kind of buggy and was not returning the right value. These changes include adding new states which read status registers to see if a reading is ready.
bradjc
previously approved these changes
Nov 27, 2023
bradjc
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request adds a few things :
Testing Strategy
Board - Nano 33 BLE Sense Rev2
Application - libtock-c program which simply calls pressure_read_sync(&press)
TODO or Help Wanted
The call to pressure_read_sync(&press) only returns data when :
Ok(pressure_value) => (kernel::errorcode::into_statuscode(Ok(())), pressure_value as usize, 0)Is changed to :
Ok(pressure_value) => (pressure_value as usize, kernel::errorcode::into_statuscode(Ok(())), 0)I think that the C API for pressure readings must be changed to accommodate this. You can find it here tock/libtock-c#351
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.