Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Jan 10, 2024

Pull Request Overview

This pull request adds syscall documentation for the KV interface.

Rendered

Testing Strategy

na

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.


**DELETE**. Delete a key-value pair from the database.

Use RO allow 0 to set the key and RO allow 1 to set the value.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need RO allow 1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interface currently uses it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We set the value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my bad.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@bradjc
Copy link
Contributor Author

bradjc commented Jan 24, 2024

This seems like an easy merge?

@lschuermann lschuermann added this pull request to the merge queue Jan 24, 2024
Merged via the queue into master with commit adb6c7b Jan 24, 2024
@lschuermann lschuermann deleted the syscall-kv-doc branch January 24, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants