kernel: SubSlice: fix slice calculation #3791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since end is calculated relative to start, if start moves up but end doesn't, we need to compensate by only including the size of the starting buffer.
lschuermann
approved these changes
Jan 12, 2024
alistair23
approved these changes
Jan 15, 2024
|
I made a note of adding unit tests in #3504 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Since end is calculated relative to start, if start moves up but end doesn't, we need to compensate by only including the size of the starting buffer.
Testing Strategy
Working on a screen driver for the ssd1306 oled.
TODO or Help Wanted
This fix got my other code working. Is there a better way to write this logic entirely? This is now the second issue.
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.