kernel: utilities: add crc32_posix #3829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
alistair23
reviewed
Feb 1, 2024
| /// Compute a POSIX-style CRC32 checksum of a slice. | ||
| /// | ||
| /// Online calculator: <https://crccalc.com/> | ||
| pub fn crc32_posix(b: &[u8]) -> u32 { |
There was a problem hiding this comment.
I think we should add unit tests. Otherwise this looks good to me
There was a problem hiding this comment.
I agree unit tests would be nice, but this seems like a function of relatively low complexity. I wouldn't want to block this PR on that.
lschuermann
approved these changes
Feb 2, 2024
2 tasks
|
Can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This is for computing short IDs from process names. Follow up to #3825.
More information here: #3825
This CRC matches the CRC TicKV uses.
Testing Strategy
The online calculator compared to tickv.
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.