Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Ioan-Cristian
Copy link
Contributor

Pull Request Overview

This pull request fixes panic printing. Previously to this pull request, if a panic occurred, first the panic banner was printed, then the content of the debug queue. This has two issues:

  1. It's confusing because temporally (logically) the content of the debug queue precedes panic banner (write event is before panic event)
  2. If you get a panic, you see the panic status along with the CPU state, but the panic banner is separated by the debug queue content. This is especially annoying in case of long debug queues when you have to pipe the output to the head command to get the panic message, file and line.

Testing Strategy

This pull request was tested by manually panicking.

TODO or Help Wanted

No help needed.

Documentation Updated

No updates are required.

Formatting

  • Ran make prepush.

@github-actions github-actions bot added the kernel label Mar 4, 2024
Copy link
Contributor

@brghena brghena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me

@alevy alevy added this pull request to the merge queue Mar 4, 2024
Merged via the queue into tock:master with commit 4a122ea Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants