test_fields!: stringify offset and size in error messages #3901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Offsets and register file size could be defined as a
constant expression like (AUX_OFFSET + 0x20).
test_fields! macro will fail for such structs as offsets go
directly to concat! macro which accepts only literals.
To avoid this failure, stringify the offset and size first.
Example:
const BAR_OFFSET: usize = 256;
register_structs! {
UartRegisters {
(0x00 => foo: ReadWrite<u32>),
(0x04 => _reserved),
((BAR_OFFSET) => bar: ReadWrite<u32>),
((BAR_OFFSET+0x04) => @EnD),
}
}
bradjc
approved these changes
Mar 5, 2024
lschuermann
approved these changes
Mar 5, 2024
brghena
approved these changes
Mar 6, 2024
|
@yuriishutkin Thanks for the improvement! I'm not sure how you're using Tock registers. If it's in Tock, you should be good after this merges. If it's external to Tock and you need an update to the tock-registers crate, let us know. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offsets and register file size could be defined as a constant expression like
(AUX_OFFSET + 0x20).test_fields!macro will fail for such structs as offsets go directly toconcat!macro which accepts only literals.To avoid this failure, stringify the offset and size first.
Example: