Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Code updates from new nightly #3921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 15, 2024
Merged

Code updates from new nightly #3921

merged 2 commits into from
Mar 15, 2024

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Mar 13, 2024

Pull Request Overview

The new nightly has new warnings. Some lingering duplicate imports, and some unused code in riscv CSRs.

Testing Strategy

make check

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@github-actions github-actions bot added chips/nrf Change pertains to the nRF5x family of MCUs. arch/risc-v RISC-V architecture WG-Network In the purview of the Network working group. labels Mar 13, 2024
hudson-ayers
hudson-ayers approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@hudson-ayers hudson-ayers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine to remove the unused code here, but I beileve we could also get rid of the warning by making the trait pub if we think anyone might want to use it eventually.

@alevy alevy added this pull request to the merge queue Mar 15, 2024
Merged via the queue into master with commit 8b6dc9a Mar 15, 2024
@alevy alevy deleted the code-updates branch March 15, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrvanwhy jrvanwhy jrvanwhy approved these changes

@hudson-ayers hudson-ayers hudson-ayers approved these changes

+1 more reviewer

@alistair23 alistair23 alistair23 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
arch/risc-v RISC-V architecture chips/nrf Change pertains to the nRF5x family of MCUs. WG-Network In the purview of the Network working group.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bradjc @alistair23 @jrvanwhy @hudson-ayers @alevy