Stopgap changes to treatment of static mut to get around compiler warnings.
#3965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3c1d4d to
66bd24f
Compare
2 tasks
bradjc
reviewed
Apr 16, 2024
boards/acd52832/src/main.rs
Outdated
Comment on lines
605
to
617
| button: button, | ||
| ble_radio: ble_radio, | ||
| console: console, | ||
| led: led, | ||
| gpio: gpio, | ||
| rng: rng, | ||
| temp: temp, | ||
| alarm: alarm, | ||
| gpio_async: gpio_async, | ||
| light: light, | ||
| buzzer: buzzer, | ||
| button, | ||
| ble_radio, | ||
| console, | ||
| led, | ||
| gpio, | ||
| rng, | ||
| temp, | ||
| alarm, | ||
| gpio_async, | ||
| light, | ||
| buzzer, |
There was a problem hiding this comment.
Getting rid of compiler warnings since the whole task was basically to get rid of compiler warnings
There was a problem hiding this comment.
These are both merged upstream.
Comment on lines
24
to
25
| use nrf52_components::{self, UartChannel, UartPins}; | ||
| use nrf52_components::{UartChannel, UartPins}; |
libraries/enum_primitive/src/cast.rs
Outdated
Comment on lines
8
to
10
| use core::{i16, i32, i64, i8, isize}; | ||
| use core::{u16, u32, u64, u8, usize}; | ||
|
|
| } | ||
|
|
||
| struct AppIdAssignerSimulated {} | ||
| pub struct AppIdAssignerSimulated {} |
|
@bradjc do you really want me to remove these changes that are redundant with other PRs fixing style/warning issues? |
Yes just merge PRs and rebase. It would be nice to just do a clean revert of this PR. |
66bd24f to
5032553
Compare
5032553 to
c22999d
Compare
|
OK, @bradjc, all done I think |
bradjc
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This change is a _stopgap_ pending a permanent, safe solution, sketched in #3945.
We can't currently update Rust compiler versions due deprecation of creating references from
&'static muts. This workaround simply replaces those with uses of theaddr_of{_mut}!macros as recommended by Rust. This should have no semantic affect on compiled artifacts.Testing Strategy
Compile tested all boards with a recent nightly
Formatting
make prepush.