Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Jul 7, 2024

Pull Request Overview

New nightlies give:

warning: /Users/bradjc/git/tock/libraries/tock-cells/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
warning: /Users/bradjc/git/tock/libraries/enum_primitive/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021

Testing Strategy

n/a

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@github-actions github-actions bot added the tock-libraries This affects libraries supported by the Tock project label Jul 7, 2024
lschuermann
lschuermann previously approved these changes Jul 8, 2024
@lschuermann lschuermann added the P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny. label Jul 8, 2024
@lschuermann lschuermann assigned lschuermann and unassigned alevy Jul 8, 2024
@lschuermann lschuermann enabled auto-merge July 8, 2024 00:54
@brghena
Copy link
Contributor

brghena commented Jul 8, 2024

The CI error here looks real. Were we previously compiling cells with a different Rust version, hiding this?

   Compiling tock-cells v0.1.0 (/home/runner/work/tock/tock/libraries/tock-cells)
error[E0432]: unresolved import `map_cell`
   --> libraries/tock-cells/src/map_cell.rs:330:9
    |
330 |     use map_cell::MapCell;
    |         ^^^^^^^^ help: a similar path exists: `crate::map_cell`
    |
    = note: `use` statements changed in Rust 2018; read more at <https://doc.rust-lang.org/edition-guide/rust-2018/module-system/path-clarity.html>

For more information about this error, try `rustc --explain E0432`.

@lschuermann lschuermann disabled auto-merge July 8, 2024 13:40
@lschuermann
Copy link
Member

lschuermann commented Jul 8, 2024

Were we previously compiling cells with a different Rust version, hiding this?

Even if you use a current Rust version, it still supports the behaviors dictated by the various Rust editions, and defaults to the 2015 edition. Crates compiled on different editions are inter-operable, so we haven't been doing anything wrong here. Edition 2015 just has a lot of legacy (such as less clear rules around imports), so we want to use the current edition everywhere.

This one's on me, didn't expect ci-tests to fail when ci-build succeeds. Good that the merge queue blocks on all of these. 😄

New nightlies give:

```
warning: /Users/bradjc/git/tock/libraries/tock-cells/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
warning: /Users/bradjc/git/tock/libraries/enum_primitive/Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
```
@lschuermann
Copy link
Member

@brghena I took the liberty to fix this import.

@lschuermann lschuermann assigned brghena and unassigned lschuermann Jul 8, 2024
@lschuermann lschuermann requested a review from brghena July 8, 2024 14:58
@brghena brghena added this pull request to the merge queue Jul 8, 2024
Merged via the queue into master with commit 305cf63 Jul 8, 2024
@brghena brghena deleted the libs-rust-edition branch July 8, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny. tock-libraries This affects libraries supported by the Tock project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants