Clippy: Move configuration to Cargo.toml #4082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every create needs ``` [lints] workspace = true ``` to use our global clippy config.
lschuermann
approved these changes
Jul 10, 2024
ppannuto
approved these changes
Jul 10, 2024
2 tasks
|
Looks like others have run into the inheritance problem as well: oxidecomputer/omicron#5715 This seems to be the relevant issue for inheritance: rust-lang/cargo#12208 |
brghena
approved these changes
Jul 11, 2024
|
Worse, if you do forget, you might end up fixing clippy lints that seem "odd" because they are on by default but all other tock code doesn't use them. |
alevy
approved these changes
Jul 11, 2024
|
the best thing about this is that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
As of last year I think (rust-lang/rfcs#3389) we can now control clippy configs in the workspace Cargo.toml. This means we do not need our run_clippy script and that
cargo clippyjust works.The downside is every Cargo.toml needs
but what can you do.
Testing Strategy
travis
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.