Fixing deferred calls registering for rp2040 rtc #4098
Conversation
| @@ -67,7 +67,6 @@ impl<D: 'static + date_time::DateTime<'static> + kernel::deferred_call::Deferred | |||
| let grant_date_time = self.board_kernel.create_grant(self.driver_num, &grant_dt); | |||
|
|
|||
| let date_time = s.write(DateTimeCapsule::new(self.rtc, grant_date_time)); | |||
| kernel::deferred_call::DeferredCallClient::register(self.rtc); | |||
There was a problem hiding this comment.
Shouldn't boards that do use the DateTime driver still have their deferred call be registered through that component? For instance, the Nucleo F429ZI also uses this component and may rely on this line to be present, right?
There was a problem hiding this comment.
I think that each driver that creates a DeferredCall instance needs to register the deferred call. In the case here, the DateTimeCapsule does not create a new DeferredCall instance and has no idea if the underlying rtc actually creates one.
There was a problem hiding this comment.
The stm32 chip does register its deferred call here
.There was a problem hiding this comment.
Gotcha, this makes sense to me! Just wanted to check that this PR doesn't inadvertently break any other boards.
It seems then that the STM board instantiation worked, but double-registered the deferred call? Looking at the kernel code, that looks like it just works right now. I'm wondering whether it'd make sense to panic in this case (perhaps configurable behind a flag).
There was a problem hiding this comment.
I think we need to check this in a better way, the bug was very subtle, took us a while to figure it out.
Pull Request Overview
This pull request fixes the rp2040 chip's
rtcdriver to register its deferred call. Before this fix, theDateTimeComponentwas registering it. This meant that any board that does not use theDateTimedriver, like the Pico Explorer Base, panics at init due to unregistered deferred call.Testing Strategy
This pull request was tested on Raspberry Pi Pico (connected to Pico Explorer Base).
TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.