clippy: deny match-single-binding
#4114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think where this was being violated is actually OK so I added an in-code allow.
lschuermann
previously approved these changes
Jul 22, 2024
alevy
previously approved these changes
Jul 23, 2024
| @@ -29,6 +29,7 @@ impl<'a> Stm32f401ccDefaultPeripherals<'a> { | |||
| } | |||
| impl<'a> kernel::platform::chip::InterruptService for Stm32f401ccDefaultPeripherals<'a> { | |||
| unsafe fn service_interrupt(&self, interrupt: u32) -> bool { | |||
| #[allow(clippy::match_single_binding)] | |||
There was a problem hiding this comment.
I guess this is OK because eventually someone might refine it more than just calling the other service_interrupt unconditionally?
There was a problem hiding this comment.
Yeah, I didn't want to just remove the // put Stm32f401cc specific interrupts here comment which seemed helpful.
ppannuto
previously approved these changes
Jul 23, 2024
5aa78f2
lschuermann
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Replace a blanket allow with the specific cases where it seems ok.
Testing Strategy
travis
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.