assemble runtime crdt state#408
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #408 +/- ##
==========================================
- Coverage 65.42% 65.34% -0.08%
==========================================
Files 125 128 +3
Lines 12253 12750 +497
==========================================
+ Hits 8016 8332 +316
- Misses 4237 4418 +181
☔ View full report in Codecov by Sentry. |
Comment on lines
+64
to
+71
| pub fn new() -> Self { | ||
| Self { | ||
| client_id: rand::random(), | ||
| guid: nanoid!(), | ||
| // share: HashMap::new(), | ||
| store: DocStore::new(), | ||
| } | ||
| } |
Check warning
Code scanning / clippy
you should consider adding a `Default` implementation for `Doc`
| for client_id in client_ids { | ||
| let refs = items.get(&client_id).unwrap(); | ||
| let mut iterator = refs.iter(); | ||
| while let Some(item) = iterator.next() { |
Check warning
Code scanning / clippy
this loop could be written as a `for` loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pr, I implemented the assembly of the crdt item into doc to provide state items that allows the operation of the list/map/text function.
Since store may be used across threads, it means that it needs to be thread-safe.