Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: refactor client sync#428

Merged
thorseraq merged 8 commits into
masterfrom
feat/refactor_client_sync
May 22, 2023
Merged

feat: refactor client sync#428
thorseraq merged 8 commits into
masterfrom
feat/refactor_client_sync

Conversation

@darkskygit
Copy link
Copy Markdown
Member

No description provided.

@darkskygit darkskygit requested a review from thorseraq May 21, 2023 13:11
@vercel
Copy link
Copy Markdown

vercel Bot commented May 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octobase ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 6:06am

Comment thread libs/jwst-rpc/src/client.rs Fixed
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2023

Codecov Report

Patch coverage: 10.47% and project coverage change: +0.70 🎉

Comparison is base (7799148) 65.73% compared to head (c1b969a) 66.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #428      +/-   ##
==========================================
+ Coverage   65.73%   66.43%   +0.70%     
==========================================
  Files         139      140       +1     
  Lines       14173    14007     -166     
==========================================
- Hits         9316     9305      -11     
+ Misses       4857     4702     -155     
Impacted Files Coverage Δ
apps/cloud/src/api/collaboration.rs 0.00% <0.00%> (ø)
apps/keck/src/server/sync/collaboration.rs 0.00% <0.00%> (ø)
libs/jwst-binding/jwst-jni/src/storage.rs 0.00% <0.00%> (ø)
libs/jwst-binding/jwst-swift/src/lib.rs 50.00% <ø> (ø)
libs/jwst-binding/jwst-swift/src/storage.rs 0.00% <0.00%> (ø)
libs/jwst-rpc/src/broadcast.rs 61.19% <ø> (-2.70%) ⬇️
libs/jwst-rpc/src/client.rs 0.00% <0.00%> (ø)
libs/jwst-rpc/src/connector/axum_socket.rs 0.00% <0.00%> (ø)
libs/jwst-rpc/src/connector/tungstenite_socket.rs 0.00% <0.00%> (ø)
libs/jwst-rpc/src/lib.rs 33.33% <0.00%> (ø)
... and 5 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@darkskygit darkskygit temporarily deployed to development May 21, 2023 13:28 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development May 21, 2023 13:28 — with GitHub Actions Inactive
@thorseraq
Copy link
Copy Markdown
Contributor

Seems there are some problems storing data to db,

using a simple test demo at libs/jwst-binding/jwst-swift/src/storage.rs

#[test]
fn write_blocks() {
  let workspace_id = "test_workspace";
  let workspace = get_workspace(workspace_id, Some(()));
  for i in 0..100 {
      let block = workspace.create(i.to_string(), "list".to_string());
      block.set_float("key".to_string(), 1.0);
  }

  sleep(std::time::Duration::from_secs(2));
}

#[test]
fn read_blocks() {
  let workspace_id = "test_workspace";
  let workspace = get_workspace(workspace_id, Some(()));
  for i in 0..100 {
      let block = workspace.get(i.to_string());
      if block.is_none() {
          println!("block {} not found", i);
      }
  }
}

@thorseraq thorseraq temporarily deployed to development May 22, 2023 05:33 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development May 22, 2023 05:33 — with GitHub Actions Inactive
Comment thread libs/jwst-binding/jwst-swift/src/storage.rs Fixed
Comment thread libs/jwst-binding/jwst-swift/src/storage.rs Fixed
Comment thread libs/jwst-binding/jwst-swift/src/storage.rs Fixed
Comment thread libs/jwst-binding/jwst-jni/src/storage.rs Fixed
Comment thread libs/jwst-binding/jwst-jni/src/storage.rs Fixed
Comment thread libs/jwst-binding/jwst-jni/src/storage.rs Fixed
@thorseraq thorseraq force-pushed the feat/refactor_client_sync branch from 0ff0608 to c1b969a Compare May 22, 2023 06:05
@thorseraq thorseraq temporarily deployed to development May 22, 2023 06:06 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development May 22, 2023 06:06 — with GitHub Actions Inactive
@thorseraq thorseraq merged commit 5c90e2a into master May 22, 2023
@thorseraq thorseraq deleted the feat/refactor_client_sync branch May 22, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants