feat: finish apply update implementation#430
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #430 +/- ##
==========================================
- Coverage 66.51% 66.13% -0.39%
==========================================
Files 140 143 +3
Lines 14007 14774 +767
==========================================
+ Hits 9317 9771 +454
- Misses 4690 5003 +313
☔ View full report in Codecov by Sentry. |
Brooooooklyn
approved these changes
May 23, 2023
000a76b to
e311112
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, almost of the apply_update stuff are done.
In this version, the update type dependency is just a simple struct need to be finished when dealing with concrete types(YText/YArray...)
More testings are on the way but this PR is so ready to be reviewed.