Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: implement YText#440

Merged
darkskygit merged 4 commits into
masterfrom
feat/ytext
Jun 1, 2023
Merged

feat: implement YText#440
darkskygit merged 4 commits into
masterfrom
feat/ytext

Conversation

@forehalo
Copy link
Copy Markdown
Collaborator

@forehalo forehalo commented May 25, 2023 •
edited
Loading

This is a fast implementation for YText without performance optimization.

We will compare it with List implementation and see if we could abstract the common part into traits or whatever.

Performance notice:

  1. without search markers, the find_position operation will be in O(n) time consumption
  2. without fast left/right/parent dereference, item.(left,right,parent) will be in O(logN) time consumption

@vercel
Copy link
Copy Markdown

vercel Bot commented May 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octobase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2023 9:39am

@forehalo forehalo temporarily deployed to development May 25, 2023 09:35 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development May 25, 2023 09:35 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development May 25, 2023 09:35 — with GitHub Actions Inactive
@forehalo forehalo self-assigned this May 25, 2023
@forehalo forehalo added the feat New feature or request label May 25, 2023
@forehalo forehalo mentioned this pull request May 25, 2023
Open
github-advanced-security[bot]
github-advanced-security AI found potential problems May 25, 2023
View reviewed changes
Comment thread libs/jwst-codec/src/doc/store.rs Fixed
Comment thread libs/jwst-codec/src/doc/store.rs Fixed
Comment thread libs/jwst-codec/src/doc/types/text.rs Fixed
Comment thread libs/jwst-codec/src/doc/types/text.rs Fixed
Comment thread libs/jwst-codec/src/doc/types/text.rs Fixed
Comment thread libs/jwst-codec/src/doc/types/text.rs Fixed
Comment thread libs/jwst-codec/src/doc/types/text.rs Fixed
Comment thread libs/jwst-codec/src/doc/types/text.rs Fixed
thorseraq
thorseraq reviewed May 26, 2023
View reviewed changes
Comment thread libs/jwst-codec/src/doc/codec/content.rs
@forehalo forehalo temporarily deployed to development May 30, 2023 07:57 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development May 30, 2023 07:57 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development May 30, 2023 07:57 — with GitHub Actions Inactive
github-advanced-security[bot]
github-advanced-security AI found potential problems May 30, 2023
View reviewed changes
Comment thread libs/jwst-codec/src/doc/store.rs Fixed
Comment thread libs/jwst-codec/src/doc/types/mod.rs Fixed
Comment thread libs/jwst-codec/src/doc/types/mod.rs Fixed
Comment thread libs/jwst-codec/src/doc/types/mod.rs Fixed
Comment thread libs/jwst-codec/src/doc/types/mod.rs Fixed
@forehalo forehalo temporarily deployed to development May 30, 2023 10:08 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development May 30, 2023 10:08 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development May 31, 2023 09:43 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development May 31, 2023 09:43 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development May 31, 2023 09:44 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development June 1, 2023 08:25 — with GitHub Actions Inactive
github-advanced-security[bot]
github-advanced-security AI found potential problems Jun 1, 2023
View reviewed changes
Copy link
Copy Markdown

@github-advanced-security github-advanced-security AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@forehalo forehalo temporarily deployed to development June 1, 2023 08:34 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development June 1, 2023 08:35 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development June 1, 2023 08:35 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2023 •
edited
Loading

Codecov Report

Patch coverage: 75.48% and project coverage change: +1.39 🎉

Comparison is base (69b1daf) 69.37% compared to head (b5a696e) 70.76%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   69.37%   70.76%   +1.39%     
==========================================
  Files         144      146       +2     
  Lines       15337    15750     +413     
==========================================
+ Hits        10640    11146     +506     
+ Misses       4697     4604      -93
Impacted Files Coverage Δ
libs/jwst-binding/jwst-jni/src/storage.rs 0.00% <0.00%> (ø)
libs/jwst-binding/jwst-swift/src/storage.rs 0.00% <0.00%> (ø)
libs/jwst-codec/src/lib.rs 100.00% <ø> (ø)
libs/jwst/src/workspace/transaction.rs 71.59% <ø> (ø)
libs/jwst-codec/src/doc/store.rs 77.07% <65.88%> (+2.02%) ⬆️
libs/jwst-codec/src/doc/document.rs 76.19% <69.23%> (+30.68%) ⬆️
libs/jwst-codec/src/doc/codec/content.rs 85.02% <71.60%> (-6.92%) ⬇️
libs/jwst-codec/src/doc/types/mod.rs 76.72% <75.92%> (+50.25%) ⬆️
libs/jwst-codec/src/doc/codec/item.rs 82.22% <76.27%> (+3.80%) ⬆️
libs/jwst-codec/src/doc/codec/refs.rs 88.28% <86.02%> (+1.79%) ⬆️
... and 3 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@forehalo forehalo temporarily deployed to development June 1, 2023 09:28 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development June 1, 2023 09:28 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development June 1, 2023 09:28 — with GitHub Actions Inactive
@darkskygit darkskygit merged commit 89d483b into master Jun 1, 2023
@darkskygit darkskygit deleted the feat/ytext branch June 1, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darkskygit darkskygit darkskygit approved these changes

+1 more reviewer

@thorseraq thorseraq thorseraq left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@forehalo forehalo

Labels

feat New feature or request

Projects

AFFiNE Project
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@forehalo @thorseraq @darkskygit @github-advanced-security