Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: marker index calc may overflow#460

Merged
darkskygit merged 1 commit into
masterfrom
fix/search-marker
Jun 12, 2023
Merged

fix: marker index calc may overflow#460
darkskygit merged 1 commit into
masterfrom
fix/search-marker

Conversation

@forehalo
Copy link
Copy Markdown
Collaborator

@forehalo forehalo commented Jun 12, 2023

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octobase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2023 3:35am

@forehalo forehalo self-assigned this Jun 12, 2023
@forehalo forehalo temporarily deployed to development June 12, 2023 03:33 — with GitHub Actions Inactive
@forehalo forehalo added the bug Something isn't working label Jun 12, 2023
@forehalo forehalo temporarily deployed to development June 12, 2023 03:33 — with GitHub Actions Inactive
@forehalo forehalo temporarily deployed to development June 12, 2023 03:33 — with GitHub Actions Inactive
@forehalo forehalo added this to the AFFiNE 0.7 milestone Jun 12, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 12, 2023

Codecov Report

Patch coverage: 66.07% and project coverage change: +0.19 🎉

Comparison is base (49a5dec) 69.39% compared to head (273a150) 69.58%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
+ Coverage   69.39%   69.58%   +0.19%     
==========================================
  Files         160      160              
  Lines       17454    17422      -32     
==========================================
+ Hits        12112    12123      +11     
+ Misses       5342     5299      -43
Impacted Files Coverage Δ
libs/jwst-codec/src/doc/codec/item.rs 75.33% <0.00%> (-0.01%) ⬇️
libs/jwst-codec/src/doc/codec/refs.rs 83.01% <29.41%> (-3.41%) ⬇️
libs/jwst-codec/src/doc/store.rs 83.66% <88.00%> (+2.32%) ⬆️
libs/jwst-codec/src/doc/types/list/mod.rs 88.41% <89.47%> (-1.00%) ⬇️
...ibs/jwst-codec/src/doc/types/list/search_marker.rs 93.40% <93.75%> (+9.53%) ⬆️
libs/jwst-codec/src/doc/types/text.rs 98.13% <100.00%> (+0.07%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 12, 2023

Benchmark Results

Linux

group                                  master                                 pr
-----                                  ------                                 --
codec/jwst decode var_int (32 bit)     1.00    363.3±0.94µs        ? ?/sec    1.00    362.7±0.31µs        ? ?/sec
codec/jwst decode var_int (64 bit)     1.00    328.8±0.07µs        ? ?/sec    1.00    329.4±1.78µs        ? ?/sec
codec/jwst decode var_uint (32 bit)    1.00    385.0±0.22µs        ? ?/sec    1.00    385.0±0.13µs        ? ?/sec
codec/jwst decode var_uint (64 bit)    1.00    368.3±0.37µs        ? ?/sec    1.00    368.4±0.46µs        ? ?/sec
codec/jwst encode var_int (32 bit)     1.00    408.1±0.11µs        ? ?/sec    1.00    408.1±0.15µs        ? ?/sec
codec/jwst encode var_int (64 bit)     1.00    446.3±4.30µs        ? ?/sec    1.00    447.4±4.52µs        ? ?/sec
codec/jwst encode var_uint (32 bit)    1.02    368.8±2.72µs        ? ?/sec    1.00    362.7±2.90µs        ? ?/sec
codec/jwst encode var_uint (64 bit)    1.00    354.8±1.36µs        ? ?/sec    1.01    358.8±3.10µs        ? ?/sec
codec/lib0 decode var_int (64 bit)     1.00    299.0±1.37µs        ? ?/sec    1.00    299.2±0.88µs        ? ?/sec
codec/lib0 decode var_uint (32 bit)    1.00    385.1±0.18µs        ? ?/sec    1.00    385.0±0.13µs        ? ?/sec
codec/lib0 decode var_uint (64 bit)    1.00    240.4±0.07µs        ? ?/sec    1.00    241.0±0.13µs        ? ?/sec
codec/lib0 encode var_int (64 bit)     1.00    469.9±2.32µs        ? ?/sec    1.00    470.5±1.78µs        ? ?/sec
codec/lib0 encode var_uint (32 bit)    1.00   387.0±11.92µs        ? ?/sec    1.01    390.8±8.26µs        ? ?/sec
codec/lib0 encode var_uint (64 bit)    1.00    399.5±1.79µs        ? ?/sec    1.00    399.2±1.44µs        ? ?/sec
operations/jwst array insert           1.33    333.3±0.50µs        ? ?/sec    1.00    250.0±0.60µs        ? ?/sec
operations/jwst array insert range     1.22   569.1±17.75µs        ? ?/sec    1.00   465.8±66.48µs        ? ?/sec
operations/yrs array insert            1.00     88.5±0.21µs        ? ?/sec    1.08     95.5±0.25µs        ? ?/sec
operations/yrs array insert range      1.00    116.0±0.57µs        ? ?/sec    1.02    118.2±0.27µs        ? ?/sec
update/parse with jwst/basic.bin       1.00     75.8±0.30µs    72.1 MB/sec    1.01     76.5±0.09µs    71.4 MB/sec
update/parse with jwst/database.bin    1.00     52.0±0.13µs    63.7 MB/sec    1.01     52.4±0.12µs    63.2 MB/sec
update/parse with jwst/large.bin       1.00      3.9±0.01ms    58.3 MB/sec    1.01      4.0±0.01ms    57.7 MB/sec
update/parse with yrs/basic.bin        1.00     44.9±0.06µs   121.6 MB/sec    1.00     44.9±0.04µs   121.5 MB/sec
update/parse with yrs/database.bin     1.00     35.7±0.07µs    92.7 MB/sec    1.01     36.1±0.04µs    91.8 MB/sec
update/parse with yrs/large.bin        1.00      2.2±0.00ms   101.9 MB/sec    1.01      2.3±0.00ms   100.8 MB/sec

Windows

group                                  master                                 pr
-----                                  ------                                 --
codec/jwst decode var_int (32 bit)     1.00    436.9±5.78µs        ? ?/sec    1.00    436.3±7.19µs        ? ?/sec
codec/jwst decode var_int (64 bit)     1.00    466.7±6.19µs        ? ?/sec    1.00    467.5±5.49µs        ? ?/sec
codec/jwst decode var_uint (32 bit)    1.00    429.9±5.88µs        ? ?/sec    1.00    430.7±6.13µs        ? ?/sec
codec/jwst decode var_uint (64 bit)    1.00    486.0±6.64µs        ? ?/sec    1.00    484.5±6.52µs        ? ?/sec
codec/jwst encode var_int (32 bit)     1.02    446.6±6.90µs        ? ?/sec    1.00    439.7±6.18µs        ? ?/sec
codec/jwst encode var_int (64 bit)     1.00    539.7±7.50µs        ? ?/sec    1.00    540.9±7.30µs        ? ?/sec
codec/jwst encode var_uint (32 bit)    1.02   374.5±10.61µs        ? ?/sec    1.00    366.1±9.67µs        ? ?/sec
codec/jwst encode var_uint (64 bit)    1.03    373.4±8.65µs        ? ?/sec    1.00    364.2±8.29µs        ? ?/sec
codec/lib0 decode var_int (64 bit)     1.00    432.5±7.21µs        ? ?/sec    1.00    431.0±5.49µs        ? ?/sec
codec/lib0 decode var_uint (32 bit)    1.00    242.6±2.85µs        ? ?/sec    1.00    242.2±2.82µs        ? ?/sec
codec/lib0 decode var_uint (64 bit)    1.01    391.3±8.51µs        ? ?/sec    1.00    388.1±4.77µs        ? ?/sec
codec/lib0 encode var_int (64 bit)     1.01   584.1±13.23µs        ? ?/sec    1.00    577.6±8.00µs        ? ?/sec
codec/lib0 encode var_uint (32 bit)    1.00    399.9±6.38µs        ? ?/sec    1.00    399.7±6.11µs        ? ?/sec
codec/lib0 encode var_uint (64 bit)    1.00    385.1±5.07µs        ? ?/sec    1.00    385.9±6.66µs        ? ?/sec
operations/jwst array insert           1.43   408.5±13.81µs        ? ?/sec    1.00    285.5±3.17µs        ? ?/sec
operations/jwst array insert range     1.00   658.9±23.45µs        ? ?/sec  
operations/yrs array insert            1.00    102.9±1.05µs        ? ?/sec    1.00    102.8±2.23µs        ? ?/sec
operations/yrs array insert range      1.00    149.3±1.41µs        ? ?/sec  
update/parse with jwst/basic.bin       1.00    115.4±1.11µs    47.3 MB/sec    1.01    117.0±1.29µs    46.7 MB/sec
update/parse with jwst/database.bin    1.00     93.7±1.17µs    35.4 MB/sec    1.01     94.2±1.31µs    35.2 MB/sec
update/parse with jwst/large.bin       1.01      5.8±0.15ms    39.4 MB/sec    1.00      5.7±0.14ms    39.9 MB/sec
update/parse with yrs/basic.bin        1.03     67.5±0.68µs    80.9 MB/sec    1.00     65.7±1.27µs    83.1 MB/sec
update/parse with yrs/database.bin     1.02     53.3±0.50µs    62.1 MB/sec    1.00     52.4±0.65µs    63.2 MB/sec
update/parse with yrs/large.bin        1.00      3.2±0.08ms    72.0 MB/sec    1.00      3.2±0.10ms    72.1 MB/sec

@darkskygit darkskygit merged commit ff4fb9e into master Jun 12, 2023
@darkskygit darkskygit deleted the fix/search-marker branch June 12, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darkskygit darkskygit darkskygit approved these changes

Assignees

@forehalo forehalo

Labels

bug Something isn't working

Projects

None yet

Milestone

AFFiNE 0.7

Development

Successfully merging this pull request may close these issues.

2 participants

@forehalo @darkskygit