Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(storage): impl BlobBucketDBStorage and BucketStorageBuilder#471

Merged
darkskygit merged 12 commits into
masterfrom
0616-bucket-storage
Jun 29, 2023
Merged

feat(storage): impl BlobBucketDBStorage and BucketStorageBuilder#471
darkskygit merged 12 commits into
masterfrom
0616-bucket-storage

Conversation

@thorseraq
Copy link
Copy Markdown
Contributor

@thorseraq thorseraq commented Jun 16, 2023 •
edited
Loading

close #465
close #463

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octobase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 10:21am

@thorseraq thorseraq temporarily deployed to development June 16, 2023 03:29 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development June 16, 2023 03:29 — with GitHub Actions Inactive
github-advanced-security[bot]
github-advanced-security AI found potential problems Jun 16, 2023
View reviewed changes
Comment thread libs/jwst-storage/src/storage/blobs/bucket_local_db.rs Fixed
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 16, 2023 •
edited
Loading

Codecov Report

Patch coverage: 23.93% and project coverage change: -0.90 ⚠️

Comparison is base (970219a) 69.21% compared to head (03eb386) 68.32%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #471      +/-   ##
==========================================
- Coverage   69.21%   68.32%   -0.90%     
==========================================
  Files         165      165              
  Lines       18209    18559     +350     
==========================================
+ Hits        12604    12680      +76     
- Misses       5605     5879     +274
Impacted Files Coverage Δ
apps/keck/src/server/sync/collaboration.rs 0.00% <0.00%> (ø)
libs/jwst-binding/jwst-jni/src/storage.rs 0.00% <0.00%> (ø)
libs/jwst-binding/jwst-swift/src/storage.rs 0.00% <0.00%> (ø)
libs/jwst-storage/src/lib.rs 100.00% <ø> (ø)
.../jwst-storage/src/storage/blobs/bucket_local_db.rs 0.00% <0.00%> (ø)
libs/jwst-storage/src/storage/blobs/utils.rs 49.68% <0.00%> (-38.10%) ⬇️
libs/jwst-storage/src/types.rs 0.00% <ø> (ø)
libs/jwst/src/types/blob.rs 0.00% <ø> (ø)
apps/keck/src/server/api/mod.rs 47.36% <28.57%> (-1.87%) ⬇️
libs/jwst-storage/src/storage/test.rs 28.00% <40.00%> (-1.17%) ⬇️
... and 8 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thorseraq thorseraq temporarily deployed to development June 16, 2023 03:46 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development June 16, 2023 03:46 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development June 16, 2023 03:46 — with GitHub Actions Inactive
@thorseraq thorseraq changed the title feature(storage): impl BlobStorage for BlobBucketDBStorage feature(storage): impl BlobBucketDBStorage and BucketStorageBuilder Jun 16, 2023
@thorseraq thorseraq force-pushed the 0616-bucket-storage branch from ff8bf74 to ac8b612 Compare June 16, 2023 07:00
@thorseraq thorseraq temporarily deployed to development June 16, 2023 07:01 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development June 16, 2023 07:01 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development June 16, 2023 07:16 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development June 16, 2023 07:16 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development June 16, 2023 07:16 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development June 18, 2023 15:16 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development June 18, 2023 15:16 — with GitHub Actions Inactive
@thorseraq thorseraq force-pushed the 0616-bucket-storage branch from fd94457 to 0831cf7 Compare June 21, 2023 09:50
@thorseraq thorseraq temporarily deployed to development June 21, 2023 09:51 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development June 21, 2023 09:51 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development June 21, 2023 09:51 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development June 24, 2023 06:05 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development June 24, 2023 06:05 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development June 24, 2023 06:05 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development June 24, 2023 06:34 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development June 24, 2023 06:34 — with GitHub Actions Inactive
@thorseraq thorseraq temporarily deployed to development June 24, 2023 06:34 — with GitHub Actions Inactive
@thorseraq thorseraq requested a review from darkskygit June 27, 2023 18:01
darkskygit
darkskygit reviewed Jun 28, 2023
View reviewed changes
Comment thread libs/jwst-storage/src/storage/blobs/bucket_local_db.rs
Comment thread libs/jwst-storage/src/storage/blobs/bucket_local_db.rs
Comment thread libs/jwst-storage/src/storage/blobs/bucket_local_db.rs
@darkskygit darkskygit temporarily deployed to development June 29, 2023 08:33 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development June 29, 2023 08:33 — with GitHub Actions Inactive
@darkskygit darkskygit temporarily deployed to development June 29, 2023 08:33 — with GitHub Actions Inactive
@darkskygit darkskygit enabled auto-merge (squash) June 29, 2023 08:39
@darkskygit darkskygit disabled auto-merge June 29, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darkskygit darkskygit darkskygit approved these changes

Assignees

@thorseraq thorseraq

Labels

None yet

Projects

AFFiNE Project
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

impl BlobStorage for BlobBucketDBStorage add builder for S3Storage

3 participants

@thorseraq @darkskygit @github-advanced-security